Introduce scene class - #583
Closed
jo-mueller wants to merge 115 commits into
Closed
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…/ome-zarr-py into introduce-scene-class
for more information, see https://pre-commit.ci
…/ome-zarr-py into introduce-scene-class
for more information, see https://pre-commit.ci
…/ome-zarr-py into introduce-scene-class
for more information, see https://pre-commit.ci
…/ome-zarr-py into introduce-scene-class
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
zarr 3.3.0 changed codec configuration attributes such as `BloscCodec.cname` and `BytesCodec.endian` from `Enum` members to plain strings, breaking the `.name` accesses in the label writer storage options tests (12 failures). Add a `_codec_value` helper that normalizes both representations, so the tests pass against zarr 3.2 and 3.3 alike. Test-only change; the library code never accessed these attributes. Assisted-by: ClaudeCode:claude-opus-5
This reverts commit dcd3858.
for more information, see https://pre-commit.ci
…/ome-zarr-py into introduce-scene-class
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…/ome-zarr-py into introduce-scene-class
for more information, see https://pre-commit.ci
…/ome-zarr-py into introduce-scene-class
Merged
Collaborator
Author
|
Continued over at #612 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #515
This is a first stab at an ome-zarr-py implementation of the scene metadata/layout that will be part of 0.6. It follows closely and builds upon the design principles of the
NgffMultiscalesclass that's introduced in #515 and mirrors the design of theNgffHCSPlateI propose in #570TODOs:
nx.DiGraphinstance?